[gl2ps] lack of build system

[Dominik 'Rathann' Mierzejewski]

Hi Christophe,

On Saturday, 03 October 2009 at 02:04, Christophe Geuzaine wrote:
[...]
> Instead of your makefile I just added our internal cmake configuration 
> file, which should do pretty much what you need. Let me know if some 
> things are missing...

I didn't have time to look at it earlier, but I tried 1.3.5 and there are
some issues. First, I don't see a way to specify where the library gets
installed. On x86_64, the library should go into /usr/lib64, but it ends
up in /usr/lib. Second, the shared library has SONAME libgl2ps.so, i.e.
without a version number. I suggest the attached patch to have proper
ABI versioning.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
-------------- next part --------------
diff -up gl2ps-1.3.5-source/CMakeLists.txt.r gl2ps-1.3.5-source/CMakeLists.txt
--- gl2ps-1.3.5-source/CMakeLists.txt.r	2009-10-16 21:14:07.000000000 +0200
+++ gl2ps-1.3.5-source/CMakeLists.txt	2009-12-26 17:23:38.000000000 +0100
@@ -116,6 +116,10 @@ if(OPENGL_FOUND)
   install(TARGETS lib shared DESTINATION lib)
 endif(OPENGL_FOUND)
 
+set_target_properties(shared PROPERTIES
+                      VERSION ${GL2PS_MAJOR_VERSION}.${GL2PS_MINOR_VERSION}.${GL2PS_PATCH_VERSION}
+                      SOVERSION ${GL2PS_MAJOR_VERSION}) 
+
 if(WIN32)
   set(GL2PS_DOC .)
 else(WIN32)